feature: Add active flag to ConstructorItem
#172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an active flag to the ConstructorItem class, allowing items to be marked as active or inactive. This addresses issue #170 by extending the item model with an active status field.
Key changes:
- Added
activeBoolean field toConstructorItemwith a default value oftrue - Added a new constructor signature accepting
id,name, andactiveparameters - Added getter and setter methods for the
activefield - Added a test case verifying that the active flag is properly persisted and retrieved
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| constructorio-client/src/main/java/io/constructor/client/ConstructorItem.java | Added active field with default value, new constructor, and accessor methods |
| constructorio-client/src/test/java/io/constructor/client/ConstructorIOItemsTest.java | Added test case to verify active flag functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
constructorio-client/src/main/java/io/constructor/client/ConstructorItem.java
Outdated
Show resolved
Hide resolved
constructorio-client/src/test/java/io/constructor/client/ConstructorIOItemsTest.java
Show resolved
Hide resolved
ahmedmaazin
force-pushed
the
feature/add-active-flag-to-constructor-item
branch
from
06fd0ff to
856c758
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
constructorio-client/src/test/java/io/constructor/client/ConstructorIOItemsTest.java
Show resolved
Hide resolved
Author
|
Closing since this PR achieves the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConstructorItem#170activeBoolean flag.